Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept folders in upload files button #4842

Merged
merged 1 commit into from
Sep 8, 2020
Merged

Accept folders in upload files button #4842

merged 1 commit into from
Sep 8, 2020

Conversation

SaraVieira
Copy link
Contributor

This PR makes it so that you can upload whole folders using the "Upload files" buttons on the sidebar using the new https://caniuse.com/#feat=input-file-directory that is supported in most browsers

In others, it just won't let you select a folder

closes #1981

@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 4, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f3189fd:

Sandbox Source
Notifications Test Configuration

@lbogdan
Copy link
Contributor

lbogdan commented Sep 4, 2020

Build for latest commit f3189fd is at https://pr4842.build.csb.dev/s/new.

Copy link
Member

@CompuIves CompuIves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!! Also nice on the deduplication!

@SaraVieira SaraVieira merged commit 7babfd4 into master Sep 8, 2020
@SaraVieira SaraVieira deleted the accept-folders branch September 8, 2020 10:54
@karlhorky
Copy link

Sweet, thanks Sara!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accept folders with upload button
4 participants