Include external resources when exporting ZIP #4843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you so much for this! Will review tomorrow :) |
|
Build for latest commit 0fc7739 is at https://pr4843.build.csb.dev/s/new. |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 0fc7739:
|
SaraVieira
reviewed
Sep 5, 2020
|
This looks really good, that is the only comment I have :D |
|
Obrigado @SaraVieira :) |
|
Again, thank you so much! |
This was referenced Oct 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Closes #2268
Closes #4048
What is the current behavior?
External resources are not included inside
public/index.htmlwhen you export the project as a ZIP file, so users have to manually fix that issue after exporting.What is the new behavior?
External resources are included inside
<head>tag.What steps did you take to test this? This is required before we can merge, make sure to test the flow you've updated.
Checklist