Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Update prettier + prettify codebase #4844

Closed
wants to merge 2 commits into from
Closed

chore: Update prettier + prettify codebase #4844

wants to merge 2 commits into from

Conversation

MichaelDeBoey
Copy link
Contributor

No description provided.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 4, 2020 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 753c9ac:

Sandbox Source
Notifications Test Configuration

@lbogdan lbogdan temporarily deployed to pr4844 September 4, 2020 23:39 Inactive
@lbogdan
Copy link
Contributor

lbogdan commented Sep 4, 2020 •
edited
Loading

Build for latest commit 753c9ac is at https://pr4844.build.csb.dev/s/new.

@MichaelDeBoey MichaelDeBoey added the dependencies Pull requests that update a dependency file label Sep 5, 2020
@lbogdan lbogdan temporarily deployed to pr4844 September 5, 2020 01:04 Inactive
@SaraVieira
Copy link
Contributor

Im sorry, I can't accept this, there are way too many files changed, this can lead to many edge cases

@SaraVieira SaraVieira closed this Sep 8, 2020
@MichaelDeBoey
Copy link
Contributor Author

@SaraVieira I think you should re-open this PR, since there's nothing changed to the code itself.

The endOfLine and trailingComma config values are now the default values, so I deleted them in our own config.
The other thing that happened is always adding brackets around function arguments (even if it's just 1 argument), so arg => implementation became (arg) => implementation.

These changes won't break anything, so please re-open this PR.

@MichaelDeBoey MichaelDeBoey mentioned this pull request Sep 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SaraVieira SaraVieira Awaiting requested review from SaraVieira

@siddharthkp siddharthkp Awaiting requested review from siddharthkp

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MichaelDeBoey @lbogdan @SaraVieira