Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new upload image functionality #495

Closed
wants to merge 6 commits into from

Conversation

wuweiweiwu
Copy link
Contributor

@wuweiweiwu wuweiweiwu commented Feb 3, 2018

What kind of change does this PR introduce?
Feature!!

What is the current behavior?
#100 currently no way to upload images.

What is the new behavior?
Added upload image icon besides create file and create directory.

on click, pop up file dialog and then the user can chose an image to upload. File is created with original name in the project.

request sent with isBinary: true

images are hosted by imgur :)

Checklist:

  • Documentation
  • Tests
  • Ready to be merged
  • Added myself to contributors table

Here is what it looks like!

giphy

@CompuIves
Copy link
Member

Wow, this looks really nice!! I can do a full review after next Monday, we have a big release planned that day.

@wuweiweiwu
Copy link
Contributor Author

@CompuIves Awesome! I look forward to it. We can also expand the functionality to upload all kinds of files. images, js source, json, etc.

@wuweiweiwu
Copy link
Contributor Author

wuweiweiwu commented Feb 13, 2018

@CompuIves bump. I will fix the merge conflicts. Or should I just create a new pull request since there has been a lot of changes since my PR

@CompuIves
Copy link
Member

CompuIves commented Feb 18, 2018

Hey @wuweiweiwu, I'm sorry for the late reply. I was working overtime for the Vue Amsterdam talk this time. Now I'm free again though.

I've been looking a bit at ways to make file upload work and I really like how Snack does it, they open this modal:

screen shot 2018-02-18 at 21 59 51

And let you drop files. I was thinking that I could open up an upload endpoint in CodeSandbox that you could call then. Then we'd return the URL to the relevant file.

I'm sorry to barge in with these ideas, I hope you're still motivated to work on this 😄. If you are, maybe it would be cool to chat to bounce some ideas around in the Discord (https://discord.gg/KE3TbEZ).

@wuweiweiwu
Copy link
Contributor Author

@CompuIves No probs! I was hoping to generalize the image upload process to other files as well :) Just joined the discord

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants