-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Docusaurus official template #5136
Conversation
Build for latest commit 40d6012 is at https://pr5136.build.csb.dev/s/new. |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 40d6012:
|
Hi @SaraVieira Was wondering if I can do anything to complete our codesandbox integration? |
Hi @SaraVieira , let me know if I can do anything to get this PR merged. I'd like to document this integration and use it for users to submit bug reports etc :) Was wondering in the meantime: what's the best way to create an equivalent of Should I just redirect my DNS record to a Docusaurus template that I imported? |
@slorber Sara will pick up your other questions, but just with regard to an always up to date template you could redirect to https://codesandbox.io/s/github/facebook/docusaurus/tree/master/examples/classic (or whichever repo you want - just alter the path), as that is synced with the repo so will remain up to date. |
Thanks @garethx , exactly what I was looking for :) I would rather have asked that sooner 😅 |
Hey! I am so sorry for this delay seriously :( We have been working on some major stuff and it completely slipped our minds to get this finished. I also needed some help with backend stuff for this. I have a meeting set up with ives to get this merged today! About the domain, we will create /s/docusaurus, that's exactly what I needed help with in the backend And yeah about new.docusaurus.io that needs to be a DNS on your side pointing to /s/docusaurus. Again, so sorry about the delay and really hoping to get this out today!! |
Thanks @SaraVieira I was already able to setup the https://new.docusaurus.io domain, so nothing hurry on my side now, as we can start adding doc for that stable URL. Just let me know when we have a shorter URL to redirect to. |
It has been merged 🔥 |
awesome, thank you :) |
Not very important but if you can replace the default nodejs icon with a custom one, that would be cool to show our mascot Slash 🤪 it helps identify Docusaurus more easily in the list |
Yeah, we did that but for some reason our cache is really not having it and it keeps returning the template as node :( We are gonna wait untill tomorrow to see if it gets updated otherwhise more digging will occur tomorrow Our logo does not have him playing keyboard guitar tho, I can change it 😂 |
Thanks :) With or without keyboard that's fine ;) |
I'm encountering some weird behaviors on our Sandbox. Using a new browser session (using my "John Doe" Chrome user or hidden session), I get this result: The errors looks related to things I did yesterday to create a bug repro for Docusaurus using CodeSandbox. Somehow it's like I managed to break that URL template, and it's now stateful and keeps my manually created errors instead of reinitializing itself from the template code on Github. It does not work better with this URL: https://codesandbox.io/s/github/facebook/docusaurus/tree/master/examples/classic However if I use the "create sandbox" feature on the UI, I get a fresh working URL: https://codesandbox.io/s/thirsty-swanson-yjqk6 Is there a way to fix https://codesandbox.io/s/docusaurus and make sure it's 100% immutable and local edits of users are not somehow persisted and shared? |
Oh, the problem seems fixed now, not sure what fixed it. Just updated our repo template here, but it's not visible in the sandbox yet: https://github.com/facebook/docusaurus/tree/master/examples/classic |
Thanks @SaraVieira , it seems to work fine now. Not sure what happened but I ended up in a weird unexpected state 😅 . I'll just upgrade my package.json name so that it does not display "examples-classic", as it seems you read the package name. However I can't use uppercase or spaces in this package-name, that would be convenient if you offered a way to specify the name that should appear in your UI as a separate config attribute somehow. Not a big deal for me though, just a suggestion. "docusaurus" will be fine :) |
Hey! It's weird, because when we deployed it we did change it to be that but I guess it did not stick for some reason, I'll ask ives to change the DB again :/ Want any description? |
Not sure where this description appears exactly but I'd be happy to have:
I'm just adding a better name to package.json in case it reproduces, so at worst it will just fallback to "docusaurus", not a big deal :) |
It's been updated :) |
It's the title that was like that, I asked Ives to update it again :)
—
Thank you
Sara Vieira
…--- original message ---
On January 20, 2021, 4:38 PM GMT+1 notifications@github.com wrote:
Thanks, I can see that :)
As there's no uppercase in Docusaurus I just wonder if it's not my "docusaurus" fallback that is being used though :p
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
--- end of original message ---
|
[NEEDS TO BE ADDED TO THE BACKEND BEFORE MERGE]
This adds all the stuff required in our code to get the new Docusaurus template up and going
closes #5135
Also merge codesandbox/codesandbox-importers#104