Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrolllock #536

Closed
wants to merge 2 commits into from
Closed

Conversation

chakrihacker
Copy link
Contributor

closes #492

Copy link
Member

@CompuIves CompuIves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is perfect! We can merge this as soon as the actions.js changes. Thanks again @chakrihacker, this is really helpful!

@@ -13,7 +13,7 @@ export function deleteSandbox({ api, state }) {
id: sandboxId,
},
})
.then(() => undefined);
.then(() => state.set(`profile.current.sandboxCount - 1`));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that this one is still from the other PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think github recognises it won't be a problem, If you want I can create new commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scroll position is not preserved when switching between tabs
2 participants