-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scrolllock #536
Scrolllock #536
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is perfect! We can merge this as soon as the actions.js
changes. Thanks again @chakrihacker, this is really helpful!
@@ -13,7 +13,7 @@ export function deleteSandbox({ api, state }) { | |||
id: sandboxId, | |||
}, | |||
}) | |||
.then(() => undefined); | |||
.then(() => state.set(`profile.current.sandboxCount - 1`)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that this one is still from the other PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think github recognises it won't be a problem, If you want I can create new commit
closes #492