Issue #547: Fixed Preview Navigator to act as normal browser on handling url history. #548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Williammer
changed the title
|
Hey @Williammer, thanks for your PR! Unfortunately this seems to break SPAs, as it will reload the frame when you press the back / forward navigation buttons in apps that use the html5 history api; for an example see https://codesandbox.io/s/zq380r0wqx vs. http://pr548.cs.lbogdan.tk/s/zq380r0wqx . |
|
(for reference, this is the PR that refactored preview history handling) |
|
@lbogdan Thanks for your information! |
|
Hey @Williammer , any updates on this? I'm thinking of closing this PR (and the corresponding issue #547 ), as the behavior of clearing the history on preview reload is expected. |
|
Sorry, I'll close it. |
This was referenced Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to fix issue #547