Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump react-devtools-inline from v4.4.0 to v4.13.2 #5654

Closed
wants to merge 4 commits into from
Closed

Bump react-devtools-inline from v4.4.0 to v4.13.2 #5654

wants to merge 4 commits into from

Conversation

iChenLei
Copy link

@iChenLei iChenLei commented Apr 12, 2021

What kind of change does this PR introduce?

Bump react-devtools-inline from v4.4.0 to v4.11.1

What is the current behavior?

It work, but lack many new feature and encount some bugs, to see react-devtools-inline CHANGELOG

What is the new behavior?

More useful feature and more bugfix. ( I contributed a bugfix facebook/react#20534

What steps did you take to test this? This is required before we can merge, make sure to test the flow you've updated.

  1. Step A
  2. Step B
  3. Step C

Checklist

  • Documentation
  • Testing
  • Ready to be merged
  • Added myself to contributors table

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 12, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d204f98:

Sandbox Source
Notifications Test Configuration

@lbogdan lbogdan temporarily deployed to pr5654 April 12, 2021 13:13 Inactive
@lbogdan
Copy link
Contributor

lbogdan commented Apr 12, 2021

Build for latest commit d204f98 is at https://pr5654.build.csb.dev/s/new.

@iChenLei
Copy link
Author

@lbogdan Hi, https://pr5654.build.csb.dev/s/new It looks like not work cause CORS, so i can't check and test React Devtools v4.11.1.

Copy link
Member

@danilowoz danilowoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @iChenLei, in order to fix the CORS issue, try to use a Google Chrome extension that allows CORS, it worked for me!

However, it seems that it introduced a new bug in the React Devtool:
Screenshot 2021-05-11 at 15 44 51

Want you to give it a shot and try to fix it? BTW, thanks for contributing!
Let me know if you need any help with this.

@iChenLei
Copy link
Author

@danilowoz I will try to resolve this problem, thanks for your advices.

Copy link
Author

@iChenLei iChenLei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update the version

yarn.lock Outdated Show resolved Hide resolved
@lbogdan lbogdan temporarily deployed to pr5654 May 13, 2021 10:24 Inactive
yarn.lock Outdated Show resolved Hide resolved
@iChenLei iChenLei changed the title Bump react-devtools-inline from v4.4.0 to v4.11.1 Bump react-devtools-inline from v4.4.0 to v4.13.2 May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants