-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump react-devtools-inline from v4.4.0 to v4.13.2 #5779
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 6c62144:
|
Build for latest commit 6c62144 is at https://pr5779.build.csb.dev/s/new. |
Yep, we get a error. Dose it is the reasom why react-devtools-inline crash ? https://pr5779-d346v.build.csb.dev it's a crashed react app. @danilowoz |
I was investigating the issue that might be causing this error in the dev tools, and it seems that the last version depends on react@experimental version. Looking at the code, we can see that it uses a method called Does it make sense? |
Thanks for your investigation, danilowoz. Maybe i need call @bvaughn (official react devtools maintainer). Hope he can solve this problem. |
Yeah, unfortunately the |
@bvaughn wooo, thanks for your fast reply. sir. Can you give me some advices for upgrade react-devtools-inline ? just keep current version and wait the stable release version? or what ? |
I think you might be okay updating to the latest 4.10 patch version, but 4.11+ integrates with new (experimental) Suspense APIs. Alternately you could update to use the experimental channel temporarily, but that's a bigger decision. |
This PR has automatically been marked stale because there has been no activity in a while. Please leave a comment if the issue has not been resolved, or if it is not stale for any other reason. After 2 weeks, this issue will automatically be closed, unless a comment is made or the stale label is removed. |
What kind of change does this PR introduce?
Bump
react-devtools-inline
from v4.4.0 to v4.13.2What is the current behavior?
It work, but lack many new feature and encount some bugs, to see react-devtools-inline CHANGELOG
What is the new behavior?
More useful feature and more bugfix. ( I contributed a bugfix facebook/react#20534
What steps did you take to test this? This is required before we can merge, make sure to test the flow you've updated.
Checklist