Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump react-devtools-inline from v4.4.0 to v4.13.2 #5779

Closed
wants to merge 2 commits into from
Closed

Bump react-devtools-inline from v4.4.0 to v4.13.2 #5779

wants to merge 2 commits into from

Conversation

iChenLei
Copy link

What kind of change does this PR introduce?

Bump react-devtools-inline from v4.4.0 to v4.13.2

What is the current behavior?

It work, but lack many new feature and encount some bugs, to see react-devtools-inline CHANGELOG

What is the new behavior?

More useful feature and more bugfix. ( I contributed a bugfix facebook/react#20534

What steps did you take to test this? This is required before we can merge, make sure to test the flow you've updated.

  1. Step A
  2. Step B
  3. Step C

Checklist

  • Documentation
  • Testing
  • Ready to be merged
  • Added myself to contributors table

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 6c62144:

Sandbox Source
Notifications Test Configuration

@lbogdan
Copy link
Contributor

lbogdan commented May 13, 2021

Build for latest commit 6c62144 is at https://pr5779.build.csb.dev/s/new.

@iChenLei
Copy link
Author

Yep, we get a error.

2021-05-13 19 53 18

Dose it is the reasom why react-devtools-inline crash ?

2021-05-13 19 55 38

https://pr5779-d346v.build.csb.dev it's a crashed react app. @danilowoz

@danilowoz
Copy link
Member

I was investigating the issue that might be causing this error in the dev tools, and it seems that the last version depends on react@experimental version. Looking at the code, we can see that it uses a method called useCacheRefresh which are only available in > 17.

Does it make sense?

@iChenLei
Copy link
Author

Thanks for your investigation, danilowoz. Maybe i need call @bvaughn (official react devtools maintainer). Hope he can solve this problem.

@bvaughn
Copy link

bvaughn commented May 13, 2021

I was investigating the issue that might be causing this error in the dev tools, and it seems that the last version depends on react@experimental version. Looking at the code, we can see that it uses a method called useCacheRefresh which are only available in > 17.

Yeah, unfortunately the react-devtools-inline package currently depends on experimental APIs that are only available in the "experimental" npm tagged release

@iChenLei
Copy link
Author

@bvaughn wooo, thanks for your fast reply. sir. Can you give me some advices for upgrade react-devtools-inline ? just keep current version and wait the stable release version? or what ?

@bvaughn
Copy link

bvaughn commented May 13, 2021

I think you might be okay updating to the latest 4.10 patch version, but 4.11+ integrates with new (experimental) Suspense APIs.

Alternately you could update to use the experimental channel temporarily, but that's a bigger decision.

@github-actions
Copy link

This PR has automatically been marked stale because there has been no activity in a while. Please leave a comment if the issue has not been resolved, or if it is not stale for any other reason. After 2 weeks, this issue will automatically be closed, unless a comment is made or the stale label is removed.

@github-actions github-actions bot added the stale label Aug 12, 2021
@iChenLei iChenLei closed this Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants