fix: don't add file extensions to resolved filepaths #6050
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Currently we call
manager.resolveTranspiledModule
infetchNPMModule#resolvePath
, but we forgot to skip the ignored extensions which adds unnecessary lookup times/latency and might actually cause issues like #6046#6046 was actually a pretty nice edge-case, apparently the packaged used has a
package.json.js
file 🤯 , see https://unpkg.com/browse/vue-instantsearch@4.0.0-beta.1/dist/vue3/es/package.json.jsFixes #6046
Closes CSB-998
What is the current behavior?
Tries different file extensions for fully resolved filepaths
What is the new behavior?
Does not try different file extensions if filepath is already fully resolved