Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't add file extensions to resolved filepaths #6050

Merged
merged 1 commit into from
Aug 19, 2021

Conversation

DeMoorJasper
Copy link
Member

@DeMoorJasper DeMoorJasper commented Aug 18, 2021

What kind of change does this PR introduce?

Currently we call manager.resolveTranspiledModule in fetchNPMModule#resolvePath, but we forgot to skip the ignored extensions which adds unnecessary lookup times/latency and might actually cause issues like #6046

#6046 was actually a pretty nice edge-case, apparently the packaged used has a package.json.js file 🤯 , see https://unpkg.com/browse/vue-instantsearch@4.0.0-beta.1/dist/vue3/es/package.json.js

Fixes #6046

Closes CSB-998

What is the current behavior?

Tries different file extensions for fully resolved filepaths

What is the new behavior?

Does not try different file extensions if filepath is already fully resolved

@lbogdan
Copy link
Contributor

lbogdan commented Aug 18, 2021

Build for latest commit 0706561 is at https://pr6050.build.csb.dev/s/new.

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 0706561:

Sandbox Source
Notifications Test Configuration
Vue InstantSearch with Vue 3 Issue #6046

@DeMoorJasper DeMoorJasper merged commit 3538272 into master Aug 19, 2021
@DeMoorJasper DeMoorJasper deleted the fix/resolution-issue-algolia branch August 19, 2021 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

module resolution issue in vue3
2 participants