Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update typescript in the editor #6232

Merged
merged 6 commits into from
Nov 2, 2021

Conversation

danilowoz
Copy link
Member

@danilowoz danilowoz commented Oct 25, 2021

@CompuIves there are minus 20k lines of code 😅, but most of these changes are related to test files.

Before After
Screenshot 2021-10-27 at 10 49 58 Screenshot 2021-10-27 at 10 50 47

Solves #6205

@codesandbox codesandbox deleted a comment from linear bot Oct 25, 2021
@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 25, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b9881af:

Sandbox Source
Notifications Test Configuration

@lbogdan lbogdan temporarily deployed to pr6232 October 25, 2021 10:06 Inactive
@lbogdan
Copy link
Contributor

lbogdan commented Oct 25, 2021

Build for latest commit b9881af is at https://pr6232.build.csb.dev/s/new.

@danilowoz danilowoz changed the title Danilo/csb 1494 feature request update typescript Update typescript in the editor Oct 25, 2021
@lbogdan lbogdan temporarily deployed to pr6232 October 27, 2021 09:48 Inactive
@lbogdan lbogdan temporarily deployed to pr6232 October 27, 2021 10:02 Inactive
@danilowoz danilowoz self-assigned this Oct 27, 2021
@danilowoz danilowoz requested a review from CompuIves October 27, 2021 10:03
@danilowoz danilowoz marked this pull request as ready for review October 27, 2021 10:03
Copy link
Member

@CompuIves CompuIves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!! LGTM!

@danilowoz danilowoz merged commit 0864028 into master Nov 2, 2021
@danilowoz danilowoz deleted the danilo/csb-1494-feature-request-update-typescript branch November 2, 2021 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants