Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Ember Support #899

Closed
wants to merge 3 commits into from

Conversation

NullVoxPopuli
Copy link
Contributor

@NullVoxPopuli NullVoxPopuli commented Jun 12, 2018

What kind of change does this PR introduce?

New Template for supporting ember-cli projects.

Related Issue: #442

What is the current behavior?

Not Working (this is a WIP, just posting the PR to show that this is being worked on)

What is the new behavior?

People should hopefully be able to demonstrate ember-apps and ember-addons with every feature ember-cli has to offer -- testing, code generation / scaffolding, etc.

(I'm also kinda selfishly working on this, because having codesandbox for ember would help out the interactiveness of my blog series of react (and it's ecosystem) vs ember)

I think codesandbox+ember would blow the pants off https://ember-twiddle.com

Checklist:

  • Documentation
  • Tests
  • Ready to be merged
  • Added myself to contributors table

Notes / questions:

  • actual template should maybe be blank, as code is generate from ember-cli.
    • maybe it should have a readme file explaining what to do with some links to resources?
    • e.g.: To make a new app, open the console, and type: ember new my-app

@NullVoxPopuli
Copy link
Contributor Author

actually, this may be held up by a lack of built-in terminal :-\

@CompuIves is there a terminal in the works?

@hakubo
Copy link

hakubo commented Jun 29, 2018

@NullVoxPopuli hey, can I help somehow with this?
@CompuIves how about the terminal? is it in the works?

@NullVoxPopuli
Copy link
Contributor Author

@hakubo of course you can help! I think my main issue was that ember-cli relies on a shell environment for dev things. I think angular gets arround this by not having the cli implemented in codesandbox, so every change is a full (probably cached?) build -- not sure how we'd want to approach that with ember, or if we'd want to keep cli usage, as the cli is half the fun. :)

@mike-north mike-north mentioned this pull request Sep 27, 2018
5 tasks
@NullVoxPopuli
Copy link
Contributor Author

superseded by #1113

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants