-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allows opening tests by default with share link #959
Conversation
@CompuIves let me know whether this is useful since we can also achieve this from sandbox config files. :) |
Yes! This is what we need! 😄 Could you also add the options to our docs? https://github.com/CompuIves/codesandbox-client/blob/master/packages/homepage/content/docs/2-embedding.md |
Everything is done, Ives! 😃 Let me know if anything is missing. |
This is almost done! The last thing we need to do is make it work in the embed, which can be done by setting the proper property here: https://github.com/CompuIves/codesandbox-client/blob/0fe309992d04fe0fc958c0125210893a90e53c73/packages/app/src/embed/components/Content/index.js#L436. |
@CompuIves It works 🎉 |
This is perfect @satyarohith, thanks a lot for the help! I'll let the build run now and merge it in as soon everything turns green. 😄🎉:shipit: |
Thanks! |
What kind of change does this PR introduce?
This PR helps us to have an option to set Tests view instead of Browser view when sharing sandboxes.
What is the current behavior?
What is the new behavior?
Checklist:
closes #958