Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add console hook to static template #943

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

SSHari
Copy link
Contributor

@SSHari SSHari commented May 20, 2023

An alternative solution to #908, based on the conversations found in the PR draft #909.

I'm not sure if adding new message types like this is ok to do, but it seems much simpler than what I was trying to do in the original implementation. That said, I'm fine with waiting on any changes until we confirm this is functionality that people actually want.

It's ok if we want to close this PR as won't do, but I just wanted to put together an example of what I was talking about in the other PR draft to help further any discussions.

@vercel
Copy link

vercel bot commented May 20, 2023

@SSHari is attempting to deploy a commit to the CodeSandbox Team on Vercel.

A member of the Team first needs to authorize it.

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 9f181b4:

Sandbox Source
Sandpack Configuration
sandpack-run-stale-value Configuration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant