Add expiration date to vouchers #477
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eslam-Nawara
force-pushed
the
add-expiration-date-to-vouchers
branch
from
c7d4a22 to
60893dd
Compare
Eslam-Nawara
force-pushed
the
add-expiration-date-to-vouchers
branch
from
76b07ee to
67fd8ff
Compare
rawdaGastan
requested changes
Dec 11, 2023
| @@ -73,23 +72,35 @@ func SetUp(t testing.TB) *App { | |||
| `, dbPath) | |||
|
|
|||
| err := os.WriteFile(configPath, []byte(config), 0644) | |||
| assert.NoError(t, err) | |||
| if !assert.NoError(t, err) { | |||
There was a problem hiding this comment.
You can use assert.error
There was a problem hiding this comment.
assert changes the state of the testing object t, fa if I used assert.Error so every time the err = nil (meaning the test had bassed), the t object would report that the test failed
server/deployer/k8s_deployer.go
Outdated
| @@ -154,6 +155,7 @@ func (d *Deployer) loadK8s(k8sDeployInput models.K8sDeployInput, userID string, | |||
| ClusterContract: int(k8sContractID), | |||
| Master: master, | |||
| Workers: workers, | |||
| ExpirationDate: time.Now().Add(time.Duration(k8sDeployInput.Duration) * 30 * 24 * time.Hour).Truncate(24 * time.Hour), | |||
There was a problem hiding this comment.
there's no time.Month duration const to use it directly, max is time.Hour fa I use it to get a month
Eslam-Nawara
requested review from
xmonader,
AlaaElattar,
AbdelrahmanElawady,
samaradel,
maayarosama and
zaelgohary
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
add expiration date to vouchers
Related Issues