-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
INI parser #1
Open
RawanMostafa08
wants to merge
31
commits into
main
Choose a base branch
from
development
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
INI parser #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RawanMostafa08
force-pushed
the
development
branch
from
September 11, 2024 12:51
5f01597
to
d2763d6
Compare
RawanMostafa08
force-pushed
the
development
branch
from
September 11, 2024 12:52
d2763d6
to
760d69b
Compare
RawanMostafa08
force-pushed
the
development
branch
from
September 16, 2024 21:08
3d13570
to
3056915
Compare
RawanMostafa08
force-pushed
the
development
branch
from
September 16, 2024 21:20
3056915
to
81265f6
Compare
AbdelrahmanElawady
requested changes
Sep 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, Rawan! Left some minor comments
…opulateINI method
…trings instead of +=
Adding the length of the array to make() function
…stead of their strings
RawanMostafa08
force-pushed
the
development
branch
from
September 24, 2024 08:36
791cc72
to
ad396fa
Compare
… return empty and not error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue link: codescalersinternships/home#279
This PR implements the following APIs for an ini files parser and their tests:
LoadFromString
LoadFromFile
GetSectionNames
list of all section namesGetSections
serialize convert into a dictionary/map{ section_name: {key1: val1, key2, val2} ...}
Get(section_name, key)
gets the value of keykey
in sectionsection_name
Set(section_name, key, value)
sets akey
in sectionsection_name
to valuevalue
ToString
SaveToFile