Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INI parser #1

Merged
merged 31 commits into from
Jan 13, 2025
Merged

INI parser #1

merged 31 commits into from
Jan 13, 2025

Conversation

RawanMostafa08
Copy link
Contributor

@RawanMostafa08 RawanMostafa08 commented Sep 10, 2024

Issue link: codescalersinternships/home#279
This PR implements the following APIs for an ini files parser and their tests:

  • LoadFromString
  • LoadFromFile
  • GetSectionNames list of all section names
  • GetSections serialize convert into a dictionary/map { section_name: {key1: val1, key2, val2} ...}
  • Get(section_name, key) gets the value of key key in section section_name
  • Set(section_name, key, value) sets a key in section section_name to value value
  • ToString
  • SaveToFile

Copy link

@AbdelrahmanElawady AbdelrahmanElawady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, Rawan! Left some minor comments

.github/workflows/main.yaml Outdated Show resolved Hide resolved
.github/workflows/main.yaml Outdated Show resolved Hide resolved
.github/workflows/main.yaml Outdated Show resolved Hide resolved
pkg/iniparser.go Outdated Show resolved Hide resolved
pkg/iniparser.go Outdated Show resolved Hide resolved
pkg/iniparser_test.go Outdated Show resolved Hide resolved
pkg/iniparser_test.go Outdated Show resolved Hide resolved
pkg/iniparser_test.go Outdated Show resolved Hide resolved
pkg/iniparser_test.go Outdated Show resolved Hide resolved
pkg/iniparser_test.go Outdated Show resolved Hide resolved
@RawanMostafa08 RawanMostafa08 merged commit dbc44fd into main Jan 13, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants