feat: trash (soft delete) #261
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR implements a soft delete (trash) feature for code snippets, changing the delete behavior from permanent deletion to moving snippets to a trashed state that can be restored.
- Implements soft delete functionality using an
activestatus of-1to mark snippets as trashed - Adds restore functionality to recover trashed snippets back to inactive state
- Updates UI components to distinguish between "Delete" (soft delete) and "Delete Permanently" actions
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| src/php/views/partials/list-table-notices.php | Updates notice messages to use "trashed" instead of "deleted" and adds new messages for permanent deletion and restoration |
| src/php/snippet-ops.php | Adds soft_delete_snippet() and restore_snippet() functions for trash functionality |
| src/php/rest-api/class-snippets-rest-controller.php | Updates REST API delete endpoint to use soft delete instead of permanent deletion |
| src/php/class-snippet.php | Adds is_trashed() method and logic to handle trashed state in snippet processing |
| src/php/class-list-table.php | Implements trash view, filtering, and action handling in the snippets list table |
| src/js/components/EditorSidebar/actions/DeleteButton.tsx | Updates delete button dialog text to reflect soft delete behavior |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
imantsk
requested changes
Oct 16, 2025
sheabunge
approved these changes
Oct 17, 2025
|
|
||
| case 'active': | ||
| return ( is_bool( $value ) ? $value : (bool) $value ) && ! $this->is_condition(); | ||
| return ( is_bool( $value ) ? $value : (bool) $value ) && ! $this->is_condition() && (int) $value != -1; |
There was a problem hiding this comment.
Might be worth changing the type of active entirely from string to int given we're using the full breadth of values.
There was a problem hiding this comment.
@sheabunge Can we maybe do this in another PR. It started looking like a big scary change 🫣
…-snippets into soft-delete merge
|
imantsk
approved these changes
Oct 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.