Skip to content

Conversation

@imantsk
Copy link
Member

@imantsk imantsk commented Oct 22, 2025

@imantsk imantsk requested review from Copilot and sheabunge and removed request for sheabunge October 22, 2025 12:22
@imantsk imantsk self-assigned this Oct 22, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes pagination functionality in the Code Snippets REST API by implementing proper pagination parameters and headers. The changes enable clients to paginate through snippet collections using standard WordPress REST API conventions.

Key changes:

  • Added support for standard REST API collection parameters (page, per_page) on the snippets endpoint
  • Implemented pagination logic with proper slicing of results and response headers (X-WP-Total, X-WP-TotalPages)
  • Updated CSS to use logical properties for better internationalization support

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
src/php/rest-api/class-snippets-rest-controller.php Added pagination support with collection parameters, page slicing logic, and standard WordPress pagination headers
src/css/settings.scss Converted directional CSS properties to logical properties for RTL language support

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

imantsk and others added 2 commits October 22, 2025 15:24
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@imantsk imantsk merged commit 1eb7967 into core-beta Oct 22, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants