review #6
Merged
review #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codesome
reviewed
Jan 23, 2019
codesome
reviewed
Jan 23, 2019
codesome
reviewed
Jan 23, 2019
compact.go
Outdated
| } else if startBlock >= 0 { | ||
| break | ||
| var overlappingTime bool | ||
| if d.meta.MinTime < maxtGlobal && d.meta.MaxTime > mintGlobal { |
codesome
reviewed
Jan 23, 2019
krasi-georgiev
force-pushed
the
pull/370-review
branch
from
ac2c412 to
159cbe3
Compare
codesome
approved these changes
Jan 23, 2019
| if len(ds) < 2 { | ||
| return nil | ||
| } | ||
| startBlock, endBlock := -1, -1 | ||
| prevMaxTime := ds[0].meta.MaxTime | ||
| var overlappingMetas []string |
There was a problem hiding this comment.
overlappingMetas -> overlappingDirs
| for i, b := range blocks { | ||
| if !overlapping { | ||
| if b.MinTime() < lastMaxT { | ||
| if i > 0 && b.MinTime() < globalMaxt { | ||
| fmt.Println(b.MinTime(), globalMaxt, b.MinTime() < globalMaxt) |
There was a problem hiding this comment.
Suggested change
| fmt.Println(b.MinTime(), globalMaxt, b.MinTime() < globalMaxt) |
| if b.MinTime() < lastMaxT { | ||
| if i > 0 && b.MinTime() < globalMaxt { | ||
| fmt.Println(b.MinTime(), globalMaxt, b.MinTime() < globalMaxt) | ||
|
|
| db, err := Open(tmpdir, nil, nil, nil) | ||
| testutil.Ok(t, err) | ||
| db.DisableCompactions() | ||
| defer func() { |
There was a problem hiding this comment.
Have a separate defer for the tempdir above (just after creating). Else if creating block or opening db is failed, we cannot do os.RemoveAll(tmpdir).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Krasi Georgiev kgeorgie@redhat.com