Add the config file option #19
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should probably add some BATS tests too... |
|
This would be great to have, since it'll allow the user to extract the config to a separate file - then usable by both CI and locally. |
8 tasks
|
@peternewman it would be great to merge this. It would make it easier to use the same config locally and on the CI. Is there something blocking it? I see version 1.18.0 was mentioned in the original description, but now that it has been released, I think this is good to go? |
|
ping on this PR. Now there is an issue it can close: #67 |
|
CIs are red and there is a conflict, @yarikoptic or @louim would you like to take over? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement codespell-project/codespell#1668 within the action.
Blocked on a new release. This needs version 1.18.0 or greater to be released to work, so we should avoid merging until then to avoid the confusion.