-
Notifications
You must be signed in to change notification settings - Fork 475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check errors don't exist as valid words in the aspell dictionary #1142
Conversation
Resync Peternewman-aspell-dict-check with master
@peternewman do you want help with this one? It seems useful |
Yeah probably. Sorry I've been tied up with lots of other stuff. I got it working and removed the ones I obviously recognised or which seemed popular, so it served it's initially purpose. My feeling was the multiple dictionary stuff probably wants doing next before the others are then migrated into a separate potential typos dictionary. I think most of these are generally unlikely to be false positives most of the time, so it seemed a shame to drop them currently. |
@peternewman I took a stab at adding multi-dict support. Can you see if these changes do something like what you'd want? If so, feel free to rebase or merge so that CIs can actually run. But tests at least pass locally |
I suspect we'll have to relax this as more obscure words won't be in the aspell dictionary
Okay @larsoner , I think the logic of this is now working as expected, certainly chancel is a valid word so I think should be in rare, but do you want to sanity check before they all get moved. Do you want to review, if you're happy move those 5 words into rare, then I'm happy for it to be merged and it probably looks better if you hit the button anyway! |
@peternewman travis is not happy |
... ahh, that's what the |
Okay let's keep things moving, thanks for the iterations @peternewman ! |
Great, thanks for doing most of the leg work on it! |
Progress on #1140 (other examples need checking)
Closes #1109
Progress on #410 (other examples need checking)
Either install for Appveyor (see here and here), ordon't require the test to run on that platform