Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check errors don't exist as valid words in the aspell dictionary #1142

Merged
merged 53 commits into from
Apr 6, 2020

Conversation

peternewman
Copy link
Collaborator

@peternewman peternewman commented May 29, 2019

Progress on #1140 (other examples need checking)
Closes #1109
Progress on #410 (other examples need checking)

  • Either install for Appveyor (see here and here), or don't require the test to run on that platform
  • Encoding - Probably need to do this too
  • Word list, pneumonic is in the large word list, but not the normal one, Br/Am English.

@peternewman peternewman added dictionary Changes to the dictionary enhancement labels May 29, 2019
@peternewman peternewman mentioned this pull request Jul 7, 2019
Resync Peternewman-aspell-dict-check with master
@larsoner
Copy link
Member

@peternewman do you want help with this one? It seems useful

@peternewman
Copy link
Collaborator Author

@peternewman do you want help with this one? It seems useful

Yeah probably. Sorry I've been tied up with lots of other stuff.

I got it working and removed the ones I obviously recognised or which seemed popular, so it served it's initially purpose. My feeling was the multiple dictionary stuff probably wants doing next before the others are then migrated into a separate potential typos dictionary. I think most of these are generally unlikely to be false positives most of the time, so it seemed a shame to drop them currently.

@larsoner
Copy link
Member

larsoner commented Apr 3, 2020

@peternewman I took a stab at adding multi-dict support. Can you see if these changes do something like what you'd want? If so, feel free to rebase or merge so that CIs can actually run. But tests at least pass locally

@peternewman
Copy link
Collaborator Author

peternewman commented Apr 6, 2020

Okay @larsoner , I think the logic of this is now working as expected, certainly chancel is a valid word so I think should be in rare, but do you want to sanity check before they all get moved.

Do you want to review, if you're happy move those 5 words into rare, then I'm happy for it to be merged and it probably looks better if you hit the button anyway!

@larsoner
Copy link
Member

larsoner commented Apr 6, 2020

@peternewman travis is not happy

@larsoner
Copy link
Member

larsoner commented Apr 6, 2020

... ahh, that's what the chancel comment is about. I'll push a commit to move

@larsoner larsoner merged commit d978da6 into master Apr 6, 2020
@larsoner
Copy link
Member

larsoner commented Apr 6, 2020

Okay let's keep things moving, thanks for the iterations @peternewman !

@larsoner larsoner deleted the peternewman-aspell-dict-check branch April 6, 2020 16:54
@peternewman
Copy link
Collaborator Author

Great, thanks for doing most of the leg work on it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dictionary Changes to the dictionary enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possible incorrect values and disable multiple choice mut is a keyword in rust
2 participants