Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spelling in snap config #2077

Merged
merged 1 commit into from
Sep 23, 2021
Merged

Fix spelling in snap config #2077

merged 1 commit into from
Sep 23, 2021

Conversation

a1346054
Copy link
Contributor

No description provided.

Copy link
Collaborator

@peternewman peternewman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but we should probably try and get to the bottom of why we haven't caught this already before we merge it.

@a1346054
Copy link
Contributor Author

There's no rush merging this PR :)

@DimitriPapadopoulos
Copy link
Collaborator

DimitriPapadopoulos commented Sep 23, 2021

Just add mispellings->misspellings to the dictionary, here, and you should be all set.

Explanation:
Currently, codespell does not catch the plural inflection when only the singular form of a typo is given. It's probably not easy to improve, especially when it comes to typos: I suspect inflect might fail on typos. What could be done, not in this PR of course, would be to make sure the plural inflection of a suggestion can be found in the dictionary when the singular form is.

peternewman added a commit that referenced this pull request Sep 23, 2021
@peternewman peternewman changed the title Fix spelling Fix spelling in snap config Sep 23, 2021
@peternewman
Copy link
Collaborator

Just add mispellings->misspellings to the dictionary, here, and you should be all set.

Thanks @DimitriPapadopoulos good spot, I'd not gone looking. Added in #2080.

Explanation:
Currently, codespell does not catch the plural inflection when only the singular form of a typo is given. It's probably not easy to improve, especially when it comes to typos: I suspect inflect might fail on typos. What could be done, not in this PR of course, would be to make sure the plural inflection of a suggestion can be found in the dictionary when the singular form is.

I see you've opened #2079 for this thanks.

@peternewman peternewman merged commit a15f3b2 into codespell-project:master Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants