Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and clarify cases in ignore patterns #3583

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

DanielYang59
Copy link
Contributor

@DanielYang59 DanielYang59 commented Nov 21, 2024

Follow up #3580 (comment).


Question:

@DimitriPapadopoulos
Copy link
Collaborator

DimitriPapadopoulos commented Nov 21, 2024

dictionary_names.txt is the same as other dictionaries: it contains potential typos with corrections.

In this case, the potential typos are valid proper nouns (names).

@DanielYang59
Copy link
Contributor Author

Hi @DimitriPapadopoulos thanks for your comment.

it contains potential typos with corrections.
In this case, the potential typos are valid proper nouns (names).

I still don't really understand the behaviour, should I expect a word in my target file like Liszt to be marked as typo or not? In my case codespell doesn't seem to flag Liszt as typo, if so why do we need this dictionary? For optional functionality maybe?

@DimitriPapadopoulos
Copy link
Collaborator

This dictionary is not part of the default dictionaries.

@DanielYang59 DanielYang59 marked this pull request as ready for review November 22, 2024 14:43
@DanielYang59
Copy link
Contributor Author

okay thanks for the reply

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants