Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Team23] 캐로셀 적용, 모달창 설계 및 구현, 상품 이미지 호버 적용 #30

Merged
merged 10 commits into from
Apr 26, 2021
Merged

[Team23] 캐로셀 적용, 모달창 설계 및 구현, 상품 이미지 호버 적용 #30

merged 10 commits into from
Apr 26, 2021

Commits on Apr 21, 2021

  1. [Add] Carousel 

    - 캐러셀 구현
- 캐러셀 틀을 잡기 위해 구조 살짝 변경 - 컴포넌트 트리 참고
- products.length가 8의 배수가 아닌 경우를 생각해서 로직을 짰는데 아직 테스트는 안해봄
    @adelakim5
    adelakim5 committed Apr 21, 2021
    Configuration menu
    Copy the full SHA
    c75cc1d View commit details
    Browse the repository at this point in the history

  2. [Fix] Carousel 

    - 4의 배수가 아닐 때 캐러셀 애니메이션 테스트함
- left 버튼을 누를 때 문제가 있었는데 index 업데이트를 수정하여 고침
    @adelakim5
    adelakim5 committed Apr 21, 2021
    Configuration menu
    Copy the full SHA
    8e42c5f View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2021

  1. [Fix] Direction of carousel-button 

    - 왼쪽 버튼을 누르면 이전 슬라이드가, 오른쪽 버튼을 누르면 이후 슬라이드가 나오도록 수정
    @adelakim5
    adelakim5 committed Apr 22, 2021
    Configuration menu
    Copy the full SHA
    1c99905 View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2021

  1. [Fix] Merge conflict 

    - 아델라의 캐로셀 코드를 demo 브랜치에 머지
    @deprecated-hongbiii
    deprecated-hongbiii committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    ccfab6b View commit details
    Browse the repository at this point in the history

  2. [Add] hover ver.1 

    - 리렌더링 때문에 깜빡거림
    @deprecated-hongbiii
    deprecated-hongbiii committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    ac9082b View commit details
    Browse the repository at this point in the history

  3. [Feat] 카드 이미지에 hover 시 배송 타입 노출

    @deprecated-hongbiii
    deprecated-hongbiii committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    27cd014 View commit details
    Browse the repository at this point in the history

  4. [Add] Modal skeleton code

    @deprecated-hongbiii
    deprecated-hongbiii committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    24fae61 View commit details
    Browse the repository at this point in the history

  5. [Refactor] Modal 컴포넌트 분리 

    - 공통적으로 사용되는 styled component를 common.jsx에 분리
- 카드에 있는 정보를 모달에 전달
    @deprecated-hongbiii
    deprecated-hongbiii committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    c3b9535 View commit details
    Browse the repository at this point in the history

  6. [Fix] 할인 전후 가격 잘못 넣어서 수정

    @deprecated-hongbiii
    deprecated-hongbiii committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    7c86069 View commit details
    Browse the repository at this point in the history

  7. [Add] Modal에 클릭한 상품의 데이터를 넣어줌

    @deprecated-hongbiii
    deprecated-hongbiii committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    70a202a View commit details
    Browse the repository at this point in the history