Test the shell code issue. #66
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Shell
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| echo $1 # Unquoted variables | ||
| find . -name *.ogg # Unquoted find/grep patterns | ||
| rm "~/my file.txt" # Quoted tilde expansion | ||
| v='--verbose="true"'; cmd $v # Literal quotes in variables |
There was a problem hiding this comment.
CodetyBot:
- 🟡 [styling] [2089] Quotes/backslashes will be treated literally. Use an array.
- 🟡 [styling] [2090] Quotes/backslashes in this variable will not be respected.
| v='--verbose="true"'; cmd $v # Literal quotes in variables | ||
| echo $1 # Unquoted variables | ||
| find . -name *.ogg # Unquoted find/grep patterns | ||
| rm "~/my file.txt" # Quoted tilde expansion |
There was a problem hiding this comment.
CodetyBot:
- 🟡 [styling] [2088] Tilde does not expand in quotes. Use $HOME.
| rm "~/my file.txt" # Quoted tilde expansion | ||
| v='--verbose="true"'; cmd $v # Literal quotes in variables | ||
| echo $1 # Unquoted variables | ||
| find . -name *.ogg # Unquoted find/grep patterns |
There was a problem hiding this comment.
CodetyBot:
- 🟡 [styling] [2061] Quote the parameter to -name so the shell won't interpret it.
- 🟡 [styling] [2035] Use ./glob or -- glob so names with dashes won't become options.
| find . -name *.ogg # Unquoted find/grep patterns | ||
| rm "~/my file.txt" # Quoted tilde expansion | ||
| v='--verbose="true"'; cmd $v # Literal quotes in variables | ||
| echo $1 # Unquoted variables |
There was a problem hiding this comment.
CodetyBot:
- 🔴 [styling] [2148] Tips depend on target shell and yours is unknown. Add a shebang or a 'shell' directive.
- 🟡 [styling] [2086] Double quote to prevent globbing and word splitting.
| echo 'Path is $PATH' # Variables in single quotes | ||
| trap "echo Took ${SECONDS}s" 0 # Prematurely expanded trap |
There was a problem hiding this comment.
CodetyBot:
- 🟡 [styling] [2064] Use single quotes, otherwise this expands now rather than when signalled.
| echo 'Path is $PATH' # Variables in single quotes | ||
| trap "echo Took ${SECONDS}s" 0 # Prematurely expanded trap | ||
| unset var[i] # Array index treated as glob |
There was a problem hiding this comment.
CodetyBot:
- 🟡 [styling] [2184] Quote arguments to unset so they're not glob expanded.
random1223
added a commit
to random1223/shellcheck
that referenced
this pull request
Sep 10, 2024
Add Codety Scanner into the static analysis solution list. Here are the examples of the result: * Codety's pull request code review example: codetyio/codety-scanner#66 (comment) * Codety's GitHub code scan result example : https://github.com/codetyio/codety-scanner/runs/29907371258 Codety Scanner is open source: https://github.com/codetyio/codety-scanner
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test the shellcheck analyzer integration.