Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sharing links to social sharing buttons #598

Open
wants to merge 1 commit into
base: development
Choose a base branch
from
Open

Add sharing links to social sharing buttons #598

wants to merge 1 commit into from

Conversation

pranshukharkwal
Copy link

I have added links to the social sharing buttons, as mentioned in #596
Apparantly Facebook and linkedin urls do not work with "localhost:5000" as domain (probably because they cannot fetch the content from them) , but I am pretty sure they will work when a publicly available domain is used because :

I tested for facebook : "https://www.facebook.com/sharer/sharer.php?u=http://example.com/some-random-alphabets"
and it works properly.

For linkedin : "https://www.linkedin.com/sharing/share-offsite/?url=http://example.com"
and it works as well.

<Button className="invite__btn">Facebook</Button>
<Button className="invite__btn">LinkedIn</Button>
<Button className="invite__btn">Twitter</Button>
<Button className="invite__btn" target = "_blank" style={{"padding-top":"6px"}} href={"https://www.facebook.com/sharer/sharer.php?u=" + inviteLink}>Facebook</Button>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @pranshukharkwal
Can you please add preview links in the form of cards when sharing?
cc @jaskiratsingh2000

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Rupeshiya
I am not exactly sure what you mean by preview links? Can you please explain? Or show an example?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean like when we use any link for sharing on LinkedIn or Twitter or any social media it shows the preview of the links. When we are sharing.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So you want preview for the Invite Link ( which would essentially be the Donut Homepage), or for the sharing link of that particular social media?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also I am thinking to use facebook graph API for link preview. What do you think? Should I go for it or you would suggest some other method?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants