Fix image gallery scrolling in editor on Safari #2088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Safari (tested with 17.3) also triggers the observer callback for children whose `intersectionRatio` is below the threshold. This only happens inside the editor iframe. In the preview or published entries, the behavior matches Chrome and Firefox. We need to double check `intersectionRatio` ourselves to prevent invoking the `onVisibleIndexChange` callback for all of the children, which leads to a broken image gallery. REDMINE-20635
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Safari (tested with 17.3) also triggers the observer callback for children whose
intersectionRatiois below the threshold. This only happens inside the editor iframe. In the preview or published entries, the behavior matches Chrome and Firefox.We need to double check
intersectionRatioourselves to prevent invoking theonVisibleIndexChangecallback for all of the children, which leads to a broken image gallery.REDMINE-20635