-
Notifications
You must be signed in to change notification settings - Fork 141
Conversation
Awesome thanks! Any idea if 1.8 may cause backwards compatibility issues? We are soon rolling out the ability to target specific language versions so if there is a chance the upgrade could break older kata we may want to support both versions. |
The Clojure rationale says that as Lisp it is not constrained by backwards compatibility. This PR goes from 1.6 to 1.8, and it looks like 1.7 has some incompatibility issues with Clojure sequences and mutating Java iterators. Not sure on the impliciations for backwards compatibility. |
OK good to know. I know nothing about Clojure. Its interesting that you didn't need to update the actual docker image to install Clojure. That means that we can target 1.6 and 1.8 within the same docker image. What would you recommend the best way to support multiple versions of the jvm-runner project, so that we can target both versions. Can we somehow support multiple |
The way to manage multiple versions can be handled through the project.clj file or with multiple profile files. You can see that here. This would probably mean a bit more scripting for firing up the separate uberjar processes as well. I was actually hoping that I could learn Clojure via kata, so I do not know best practices for versioning and would need to defer to someone else. By the way, Codewars is great. It has definitely been helpful. Thanks for your work. |
Good point. I'll update to 1.8 and verify each kata to make sure backwards compatibility issues aren't a problem before going down that path.
Thanks. I'm glad you are getting benefit from it. |
Just wondering what happened after the merge. codewars.com still has only Clojure 1.6. I really miss transducers, for example, they often lead to elegant solutions. But surely, I agree, codewars is great! :) |
@egri-nagy I just tried @jhoffner |
Updated Clojure to version 1.8 and bumped jvm-runner project version from 0.1.1 to 0.1.2