Skip to content
This repository was archived by the owner on Oct 14, 2020. It is now read-only.

Updated Clojure #136

Merged
merged 3 commits into from
May 7, 2016
Merged

Conversation

nrakochy
Copy link
Contributor

@nrakochy nrakochy commented May 5, 2016

Updated Clojure to version 1.8 and bumped jvm-runner project version from 0.1.1 to 0.1.2

@jhoffner
Copy link
Member

jhoffner commented May 7, 2016

Awesome thanks!

Any idea if 1.8 may cause backwards compatibility issues? We are soon rolling out the ability to target specific language versions so if there is a chance the upgrade could break older kata we may want to support both versions.

@nrakochy
Copy link
Contributor Author

nrakochy commented May 7, 2016

The Clojure rationale says that as Lisp it is not constrained by backwards compatibility.

This PR goes from 1.6 to 1.8, and it looks like 1.7 has some incompatibility issues with Clojure sequences and mutating Java iterators.

Not sure on the impliciations for backwards compatibility.

@jhoffner
Copy link
Member

jhoffner commented May 7, 2016

OK good to know. I know nothing about Clojure. Its interesting that you didn't need to update the actual docker image to install Clojure. That means that we can target 1.6 and 1.8 within the same docker image.

What would you recommend the best way to support multiple versions of the jvm-runner project, so that we can target both versions. Can we somehow support multiple project.clj files?

@nrakochy
Copy link
Contributor Author

nrakochy commented May 7, 2016

The way to manage multiple versions can be handled through the project.clj file or with multiple profile files. You can see that here. This would probably mean a bit more scripting for firing up the separate uberjar processes as well.

I was actually hoping that I could learn Clojure via kata, so I do not know best practices for versioning and would need to defer to someone else.

By the way, Codewars is great. It has definitely been helpful. Thanks for your work.

@jhoffner
Copy link
Member

jhoffner commented May 7, 2016

This would probably mean a bit more scripting for firing up the separate uberjar processes as well

Good point. I'll update to 1.8 and verify each kata to make sure backwards compatibility issues aren't a problem before going down that path.

Codewars is great

Thanks. I'm glad you are getting benefit from it.

@jhoffner jhoffner merged commit 82a4334 into codewars:master May 7, 2016
@egri-nagy
Copy link

Just wondering what happened after the merge. codewars.com still has only Clojure 1.6.

I really miss transducers, for example, they often lead to elegant solutions.

But surely, I agree, codewars is great! :)

@kazk
Copy link
Member

kazk commented Jun 23, 2017

@egri-nagy I just tried (println *clojure-version*) in Kumite and apparently we have 1.8.0 :/
image

@jhoffner #versions dropdown needs update.
image

@kazk kazk mentioned this pull request Jul 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants