Skip to content
This repository was archived by the owner on Oct 14, 2020. It is now read-only.

Conversation

@wizzup
Copy link
Contributor

@wizzup wizzup commented Nov 9, 2016

Update haskell system to newer lts-6.24 version (compared to #270)

Please murge this to a new feature/haskell-7.10 branch while testing #270 (2ede419) on master.

This commit contain non-trival change to codewars's haskell framework.

I have no idea how to fully test it beside test/runners/haskell_spec.js on docker build

wizzup and others added 4 commits November 9, 2016 12:04
update make recent
there is some problem with node on travis server.
node doesn't required to build docker image anyway.
pass all test in test/runners/haskell_spec.js
remove esqueleto because it not in lts-6.24 (it never used for test anyway)
update haskell framework to fix some type mismatch
@wizzup wizzup changed the title Feature/haskell 7.10 feature/haskell 7.10 Nov 9, 2016
@buzzdecafe buzzdecafe mentioned this pull request Nov 15, 2016
@jhoffner
Copy link
Member

jhoffner commented Nov 15, 2016

Awesome @wizzup thanks! Is the non-trivial change to the test framework backwards compatible? It looks like it might be to me but I don't know Haskell.

@wizzup
Copy link
Contributor Author

wizzup commented Nov 16, 2016

Is the non-trivial change to the test framework backwards compatible?

No, if you use the old code from old docker, the framework would not compiled due to difference in function types signature among different hspec version.

But if you mean testing user-submitted code via codewars hspec wrapper in this docker, it should be ok since it pass all test in codewars-runner-cli/test/runners/haskell_spec.js with only single modification on the last test.

I would recommend setting thing like a beta integration test on codewars site or find the way to pull submitted codes to re-run on this docker and see if any of it failed.

I am not a Haskell expert. I might miss something.

@wizzup wizzup closed this Nov 16, 2016
@wizzup wizzup reopened this Nov 16, 2016
@jhoffner jhoffner merged commit 52c2c4a into codewars:master Dec 3, 2016
@wizzup wizzup deleted the feature/haskell-7.10 branch December 3, 2016 04:24
This was referenced Jul 14, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants