-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deduplicate - validate sudoku board #171
Comments
Kata 1. and 2. are exact duplicates, and both are a subset of 3. I am not sure if 3. is a duplicate because of a more generic problem, but I would be happy to get rid of it if only for the maintenance cost it currently imposes. I am also not sure if 3. is related to actual sudokus, so maybe 1. or 2. are simply more appropriate. I also don't like how the problem is presented in 1. because I feel that "a(n un)finished sudoku" is IMO not really a good description. Generally, this set of kata makes me not sure how to proceed. Whichever kata are chosen to stay, they will need a lot of attention and effort to bring them to a good shape. All three are a clusterf**k of issues, from missing tests to terrible feedback to insufficient descriptions (users are constantly tripping over and/or complaining about insufficient explanation of "boxes"). IMO there is no good choice. However, possible options are:
Maybe someone has some other ideas. |
The rank of 2 does not seem to fit standards nowadays! I suggest the 2nd opinion: keep 1 and 3. And I don't think we need to transfer any languages from 2 to 1 or 3, since most of them are in bad shape. |
They are all severely overranked, this task is 6kyu at most.
Vote to keep 2. and rerank. Retire the rest. |
not possible to rerank: too many completions. I'd almost retire the three of them... |
I agree with B4B and/or Madjosz if we must keep 1 of them: kata 2 is the "least bad" and requires least work. I think unfortunately that it is worth keeping one such kata mainly because otherwise the Beta process will be full of people re-submitting Sudoku katas when they don't find one in the catalogue (since it's a classic in intro books/courses). If the main argument against kata 2 is that it is really overranked, and can't be reranked, well maybe it's an acceptable compromise? It can act as many users' first Blue and be a nice little freebie? Finally, I note from reading comments on the 3 katas that many users have provided specific fixed tests that invalidate solutions - as a maintenance activity it would be a nice idea to collect all these examples and paste them into whichever kata gets to stay while waiting for menders to make full random tests. |
We don't actually "must" do anything particular, and I think other solutions are also possible. For example, we could retire all three and replace them with a new kata, build from ground up, but correctly (or, at least, to hope so). This is something I considered for some kata which cannot be easily deduplicated because all alternatives are bad, but this is not easy, and the method is not well established, so it would have to be carefully thought through. If you ask me, I think I'd like this approach the most: retire all three kata, publish a new one as a beta, and hope that it will attract translations, get approved, and serve as a replacement for the current, bad ones. |
Keep 1 and 3. At the very least Scala can be copy pasted from 2 to 1, since I wrote that pretty recently. I thought we added random tests to 3 for Python as well when we made the Scala translation, but that should be pretty easy to fix as well. I want to keep 3 as it does have some worth as a generalisation of the task. |
I think now we can test out following procedure: I created a new kata from scratch: Sudoku board validator. I will publish it as a beta kata and add a note that it's meant as a replacement. Let's see how reviewers see the idea of replacements. If it gets to an approvable shape, it could be approved with rank determined by votes, have translations added, etc. Afterwards, we will ask to retire the two existing 9x9 kata. |
Well, with that kata the first two katas in question should be retired 'cuz the solution from the newest kata can be applied to them. In advance, the NxN kata should be keeped because it's not as trivial, imo (also, why new kata has 9x9 grid, not NxN?) |
Yes, they are planned to be retired.
I tried to explain this in this post. |
I think those 2 old kata could be retired right away. This could avoid the extra use of the solutions of the new kata to grab easy points 4500zenja1 is talking about. Since we have the links to the old ones here, all translations there would still be accessible. |
Thats a good idea, i did not think the new kata will collect enough votes so quickly. |
I think everyone looking here or at discord knows the intent, so I'm not surprised. As long as it doesn't come out of the blue, I think the process should succeed. |
A follow-up discussion on "Validate Sudoku with size |
Did I Finish my Sudoku?
Sudoku Solution Validator
Validate Sudoku with size
NxN
Conclusion
NxN
The text was updated successfully, but these errors were encountered: