Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sales): replaces then with asyncSpawn #1036

Merged
merged 1 commit into from
Dec 16, 2024
Merged

fix(sales): replaces then with asyncSpawn #1036

merged 1 commit into from
Dec 16, 2024
+20 −22

Conversation

emizzle
Copy link
Contributor

@emizzle emizzle commented Dec 12, 2024

  • ensures addSlotToQueue does not raise exceptions as it is now asyncSpawned

Notes

@emizzle emizzle force-pushed the fix/fix-async-futures/4-sales branch from b7443c2 to f87ef3a Compare December 12, 2024 06:45
markspanbroek
markspanbroek approved these changes Dec 12, 2024
View reviewed changes
Copy link
Member

@markspanbroek markspanbroek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @emizzle!

@emizzle emizzle force-pushed the fix/fix-async-futures/3-slotqueue branch from 61de014 to 23c9ec2 Compare December 13, 2024 00:32
@emizzle emizzle force-pushed the fix/fix-async-futures/4-sales branch from f87ef3a to a42ae34 Compare December 13, 2024 00:32
@emizzle emizzle force-pushed the fix/fix-async-futures/3-slotqueue branch from 23c9ec2 to aabf4b4 Compare December 13, 2024 04:06
Base automatically changed from fix/fix-async-futures/3-slotqueue to master December 13, 2024 08:08
@emizzle
fix(sales): replaces then with asyncSpawn
52a457f 
- ensures `addSlotToQueue` does not raise exceptions as it is now asyncSpawned
@emizzle emizzle force-pushed the fix/fix-async-futures/4-sales branch from a42ae34 to 52a457f Compare December 13, 2024 23:13
@emizzle emizzle added this pull request to the merge queue Dec 15, 2024
Merged via the queue into master with commit 01fb685 Dec 16, 2024
17 checks passed
@emizzle emizzle deleted the fix/fix-async-futures/4-sales branch December 16, 2024 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markspanbroek markspanbroek markspanbroek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emizzle @markspanbroek