[feat] Add support for content ranges/seeking #1218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Currently this implementation relies on retrieving the entire file (in the case of a node that doesn't have the full content) before it streams from a position, which is pretty inefficient. Looking into fixes. |
|
Do not merge yet - |
|
How is this looking @Zorlin ?:) I could really use it for one of my hacks:D |
Will be doing a rewrite based on the latest code, and get back to you soon 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very naive implementation, but in local testing it works! Use VLC and stream a video and you can repeatedly seek within it.