Ensures same verifier artifacts are used for release tests as testnet #1277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Building an updated image here: https://github.com/codex-storage/nim-codex/actions/runs/15706842697 |
|
Confirmed: Release tests on this image are now failing with exactly the same error as we see in the testnet. This will help us not make this mistake again. |
|
Merging this PR will not be necessary. This fix will be included in: |
|
Can we close this now @benbierens? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verifier artifacts in nim-codex release v0.2.4 were broken. This was not detected by the containerized testing setup, because, it has its own verifier/networks folder and artifacts.
This PR deletes those artifacts and uses a symlink to ensure that the tests are running on the same artifacts that would be used for the testnet. This will help us detect verifier-related issues in the dist/release tests.