Caret module: initial #242
Conversation
khaydarov
requested review from
gohabereg,
neSpecc and
talyguryn
as code owners
| */ | ||
| constructor() { | ||
|
|
||
| this.instance = null; |
There was a problem hiding this comment.
Зачем это, если все методы статичны?
src/components/utils.js
Outdated
| * Returns basic nodetypes as contants | ||
| * @return {{TAG: number, TEXT: number, COMMENT: number, DOCUMENT_FRAGMENT: number}} | ||
| */ | ||
| static get nodeTypes() { |
There was a problem hiding this comment.
Для этого вроде какая-то нативная штука появилась
There was a problem hiding this comment.
$1.nodeType === Node.ELEMENT_NODE
$1.nodeType === Node.TEXT_NODE etc
| * @param {Node} node | ||
| * @return {*|boolean} | ||
| */ | ||
| static isLeaf(node) { |
src/components/dom.js
Outdated
| /** | ||
| * checks node if it is doesn't have child node | ||
| * @param {Node} node | ||
| * @return {*|boolean} |
There was a problem hiding this comment.
Why return type is any? Seems like it always returns boolean
src/components/dom.js
Outdated
| } | ||
|
|
||
| /** | ||
| * checks node if it is doesn't have child node |
src/components/dom.js
Outdated
| } | ||
|
|
||
| /** | ||
| * Creates text Node with content |
There was a problem hiding this comment.
Creates Text Node with the passed content
src/components/dom.js
Outdated
| } | ||
|
|
||
| /** | ||
| * Search for deepest node |
src/components/dom.js
Outdated
| * | ||
| * @return {Boolean} true if it is empty | ||
| */ | ||
| static checkNodeEmpty(node) { |
src/components/dom.js
Outdated
|
|
||
| nodeText = node.value; | ||
|
|
||
| if ( nodeText.trim() ) { |
There was a problem hiding this comment.
You can move this block under the
if ( this.isElement(node) && this.isNativeInput(node) ) {
} else {
}and remove similar one from the second part
There was a problem hiding this comment.
And replace it with
return nodeText.trim().length === 0;
src/components/dom.js
Outdated
| } | ||
|
|
||
| /** | ||
| * breadth-first search |
There was a problem hiding this comment.
It doesn't looks like anyone can understand this.
|
|
||
| if (!node) { | ||
|
|
||
| return false; |
There was a problem hiding this comment.
undefined is not empty Node? Maybe you should throw an Error there? or add a console.assert
src/components/dom.js
Outdated
| static isEmpty(node) { | ||
|
|
||
| let treeWalker = [], | ||
| stack = []; |
src/components/utils.js
Outdated
| * Returns basic nodetypes as contants | ||
| * @return {{TAG: number, TEXT: number, COMMENT: number, DOCUMENT_FRAGMENT: number}} | ||
| */ | ||
| static get nodeTypes() { |
There was a problem hiding this comment.
$1.nodeType === Node.ELEMENT_NODE
$1.nodeType === Node.TEXT_NODE etc
| break; | ||
| case _.keyCodes.DOWN: | ||
| case _.keyCodes.RIGHT: | ||
| this.blockRightOrDownArrowPressed(); |
| break; | ||
| case _.keyCodes.UP: | ||
| case _.keyCodes.LEFT: | ||
| this.blockLeftOrUpArrowPressed(); |
| */ | ||
| blockRightOrDownArrowPressed() { | ||
|
|
||
| let currentBlock = this.currentBlock, |
| lastTextNode = $.getDeepestTextNode(currentBlock.pluginsContent, true), | ||
| textNodeLength = lastTextNode.length; | ||
|
|
||
| if (Selection.getSelectionAnchorNode() !== lastTextNode) { |
|
|
||
| /** | ||
| * | ||
| * @return {*} |
| } | ||
|
|
||
| /** | ||
| * |
| } | ||
|
|
||
| /** | ||
| * |
| * Returns next Block instance | ||
| * @return {*} | ||
| */ | ||
| getNextBlock() { |
There was a problem hiding this comment.
It can be implemented via getter nextBlock
| /** | ||
| * Returns previous Block instance | ||
| */ | ||
| getPreviousBlock() { |
There was a problem hiding this comment.
It can be implemented via getter previousBlock
docs/caret.md
Outdated
| @@ -0,0 +1 @@ | |||
| # CodeX Editor Caret Module No newline at end of file | |||
|
|
||
| } | ||
|
|
||
| if (Selection.getSelectionAnchorOffset() === textNodeLength) { |
| let lastTextNode = $.getDeepestNode(this.currentBlock.pluginsContent, true), | ||
| textNodeLength = lastTextNode.length; | ||
|
|
||
| if (Selection.getSelectionAnchorNode() !== lastTextNode) { |
| /** | ||
| * @todo Refactor method when code above will be moved to the keydown module | ||
| */ | ||
| navigatePrevious() { |
| /** | ||
| * @todo Refactor method when code above will be moved to the keydown module | ||
| */ | ||
| navigateNext() { |
src/components/modules/ui.js
Outdated
| let clickedNode = event.target; | ||
|
|
||
| console.log('click', clickedNode); | ||
| if ( clickedNode.classList.contains(this.CSS.editorZone) ) { |
There was a problem hiding this comment.
It won't work with clicks on inner-elements. What behaviour do you expect?
There was a problem hiding this comment.
And it is already working with setToTheLastBlock. See below
src/components/modules/ui.js
Outdated
|
|
||
| } | ||
|
|
||
| clickedOnRedactorZone(event) { |
There was a problem hiding this comment.
| /** | ||
| * Working with selection | ||
| */ | ||
| export default class Selection { |
There was a problem hiding this comment.
Bad name, that conflicts with window.Selection
src/components/selection.js
Outdated
|
|
||
| } | ||
|
|
||
| static getSelection() { |
There was a problem hiding this comment.
redundant Selection-word all method's names.
src/components/selection.js
Outdated
|
|
||
| } | ||
|
|
||
| static getSelection() { |
src/components/modules/caret.js
Outdated
| * If last block is empty and it is an initialBlock, set to that. | ||
| * Otherwise, append new empty block and set to that | ||
| */ | ||
| if ($.isEmpty(pluginsContent)) { |
There was a problem hiding this comment.
лучше оставить геттер isEmpty у Block. Там проверяется не только пустота контента. Можешь принести туда свой $.isEmpty вместо this._html.textContent.trim().length === 0
|
|
||
| } | ||
|
|
||
| _.delay( () => this.set(nodeToSet, offset), 20)(); |
No description provided.