Add example-dev.html #657
Merged
Add example-dev.html #657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PolinaShneider
requested review from
neSpecc,
khaydarov,
talyguryn and
gohabereg
neSpecc
requested changes
Mar 18, 2019
example/example.html
Outdated
| <script src="https://cdn.jsdelivr.net/npm/@editorjs/embed@latest"></script><!-- Embed --> | ||
| <script src="https://cdn.jsdelivr.net/npm/@editorjs/table@latest"></script><!-- Table --> | ||
| <script src="https://cdn.jsdelivr.net/npm/@editorjs/link@latest"></script><!-- Link --> | ||
| <script src="https://cdn.jsdelivr.net/npm/@editorjs/raw@latest"></script><!-- Raw --> |
There was a problem hiding this comment.
Raw надо убрать из этого экзампла, в деве можно оставить
talyguryn
requested changes
Mar 18, 2019
package.json
Outdated
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "@editorjs/editorjs", | |||
| "version": "2.11.11", | |||
| "version": "2.11.12", | |||
There was a problem hiding this comment.
версию можно не бампать. редактор-то не обновлен.
| @@ -45,21 +45,20 @@ | |||
| Read more in Tool's README file. For example: | |||
There was a problem hiding this comment.
что нужно сделать с файлом, чтобы он стал доступен в github pages? можно сделать так, чтобы этот пример всегда был разлит там и доступен
There was a problem hiding this comment.
Надо назвать index.html и положить в корень или в docs
neSpecc
approved these changes
Mar 22, 2019
talyguryn
approved these changes
Mar 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make
example-dev.htmlfor debugging andexample.htmlfor demo-purposes