Skip to content

Refactor tests for team rights #207

Open
@GoldenJaden

Description

@GoldenJaden

Problem

With the come of team rights policies, there are a lot of almost indentical tests that should be run for some routes.

Solution

Parametrize tests that test team rights - make use of the test.each method to stuff similar test to one pack.

You can peek into the note.settings.test.ts to understand how it should be done.

Also, it would be nice to save this test.each as separate util for better convenience:
something like

test.roles = test.each([{ role: MemberRole.Read,
        isPublic: false,
        isAuthorized: true,
        statusCode: 200 },
        { ... },
        { ... },
        { ... }
]);

and use it as

test.roles('Returns note with access rights by public id ....', ({ role, isPublic, isAuthorized, statusCode }) => {

})

Tasks

  • Refactor tests regarding team rights
  • Make the method as a separate util
  • Find out how to make the better
    naming for tests in test.each (from jest tool). Right now we have same name for all tests in one scope, and it's not very convenient.
  • Update test docs

Metadata

Metadata

Assignees

Labels

TestsThis issue is related to writing or modifying tests

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions