Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): add a sticky navbar #282

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

feat(ui): add a sticky navbar #282

wants to merge 5 commits into from

Conversation

Dobrunia
Copy link
Contributor

Partially resolves #281

  • implement layout navbar component
  • Added sticky positioning to the navbar
  • Integrated the component into the playground environment
  • Implemented left/right slots for flexible content placement

@Dobrunia Dobrunia requested review from neSpecc and GeekaN2 December 16, 2024 16:18
<div class="navbar-wrapper">
<Navbar>
Left
<template #navbar__right>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<template #navbar__right>
<template #right>

background-color: var(--base--bg-secondary);
border-radius: var(--radius-m);
border: 1px solid var(--base--border);
overflow-x: clip;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it used?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, for demo


.navbar {
z-index: 1;
top: 52px;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unhardcode header height


<style scoped lang="postcss">
.navbar {
position: sticky;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use 2 space indentation, please

@Dobrunia Dobrunia requested a review from neSpecc December 24, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sticky Navbar on Scroll
2 participants