Skip to content

pop_left and pop_right returns value #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 6, 2020
Merged

pop_left and pop_right returns value #125

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,3 +58,9 @@ __pycache__/
################
.vscode/
.vs/

# Other Files #
################
.idea/
build/
dist/
8 changes: 4 additions & 4 deletions pydatastructs/linear_data_structures/linked_lists.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,7 @@ def pop_left(self):
The leftmost element of linked
list.
"""
self.extract(0)
return self.extract(0)

def pop_right(self):
"""
Expand All @@ -224,7 +224,7 @@ def pop_right(self):
The leftmost element of linked
list.
"""
self.extract(-1)
return self.extract(-1)

def extract(self, index):
"""
Expand Down Expand Up @@ -435,7 +435,7 @@ def pop_left(self):
The leftmost element of linked
list.
"""
self.extract(0)
return self.extract(0)

def pop_right(self):
"""
Expand All @@ -449,7 +449,7 @@ def pop_right(self):
The leftmost element of linked
list.
"""
self.extract(-1)
return self.extract(-1)

def extract(self, index):
"""
Expand Down
16 changes: 8 additions & 8 deletions pydatastructs/linear_data_structures/tests/test_linked_lists.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@ def test_DoublyLinkedList():
dll.insert_at(0, 2)
dll.insert_at(-1, 9)
dll.extract(2)
dll.extract(0)
dll.extract(-1)
assert dll.pop_left().data == 2
assert dll.pop_right().data == 4
dll[-2].data = 0
assert str(dll) == "[7, 5, 1, 6, 1, 0, 9]"
assert len(dll) == 7
Expand Down Expand Up @@ -50,8 +50,8 @@ def test_SinglyLinkedList():
sll.insert_at(0, 2)
sll.insert_at(-1, 9)
sll.extract(2)
sll.extract(0)
sll.extract(-1)
assert sll.pop_left().data == 2
assert sll.pop_right().data == 6
sll[-2].data = 0
assert str(sll) == "[2, 4, 1, 0, 9]"
assert len(sll) == 5
Expand Down Expand Up @@ -83,8 +83,8 @@ def test_SinglyCircularLinkedList():
scll.insert_at(0, 2)
scll.insert_at(-1, 9)
scll.extract(2)
scll.extract(0)
scll.extract(-1)
assert scll.pop_left().data == 2
assert scll.pop_right().data == 6
scll[-2].data = 0
assert str(scll) == "[2, 4, 1, 0, 9]"
assert len(scll) == 5
Expand Down Expand Up @@ -118,8 +118,8 @@ def test_DoublyCircularLinkedList():
dcll.insert_at(0, 2)
dcll.insert_at(-1, 9)
dcll.extract(2)
dcll.extract(0)
dcll.extract(-1)
assert dcll.pop_left().data == 2
assert dcll.pop_right().data == 4
dcll[-2].data = 0
assert str(dcll) == "[7, 5, 1, 6, 1, 0, 9]"
assert len(dcll) == 7
Expand Down