-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate the project to Poetry #443
base: main
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## master #443 +/- ##
=========================================
Coverage 98.588% 98.588%
=========================================
Files 29 29
Lines 3754 3754
=========================================
Hits 3701 3701
Misses 53 53 |
Is |
Hi @czgdp1807 This is my first attempt at migrating the project to Poetry. Please have a look and let me know the apt changes required. Based on my guesswork, these are the things that would be left:
|
It is required to lock all the developers to the same set of dependencies as everyone else is using. More about this on the Docs here: https://python-poetry.org/docs/basic-usage/#installing-with-poetrylock |
Can we reduce the dependencies there then? We only use the following. Python should be a minimum of 3.8 from 1.0.1.
|
Let's keep |
I would suggest having two workflows, one using |
Description
This PR: