Encode 'service' query parameter in Admin UI logout links #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
blen-desta
approved these changes
Sep 11, 2020
4 tasks
|
I successfully heroed this with codice/ddf#6310 👍 |
Merged
4 tasks
parret
approved these changes
Sep 17, 2020
stustison
approved these changes
Sep 21, 2020
|
build now |
6 similar comments
|
build now |
|
build now |
|
build now |
|
build now |
|
build now |
|
build now |
|
Internal build has been started, your results will be available at build completion. |
|
Build SUCCESS See the job results in legacy Jenkins UI or in Blue Ocean UI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This was inspired by this PR: codice/ddf#6310
I'm not aware of any current bugs caused by the unencoded query parameter, but URIs may contain characters that could cause issues (e.g.
&). This change is to be safe.Reviewers
@blen-desta @bakejeyner @emmberk @garrettfreibott @stustison