Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add databinding to activities #71

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add databinding to activities #71

wants to merge 2 commits into from

Conversation

AkshayCHD
Copy link

@AkshayCHD AkshayCHD commented May 17, 2018

Used databinding in the activites java files to reduce the boilerplate code.
fixes #72

@championswimmer
Copy link
Contributor

Please fix the codacy issues and make sure the tests do not fail

@championswimmer
Copy link
Contributor

Check the error (UI tests) here https://travis-ci.org/coding-blocks/DigitalOceanApp/jobs/380232125

@coding-blocks coding-blocks deleted a comment May 17, 2018
@coding-blocks coding-blocks deleted a comment May 17, 2018
@coding-blocks coding-blocks deleted a comment May 17, 2018
@coding-blocks coding-blocks deleted a comment May 17, 2018
@coding-blocks coding-blocks deleted a comment May 17, 2018
@coding-blocks coding-blocks deleted a comment May 17, 2018
@coding-blocks coding-blocks deleted a comment May 17, 2018
@coding-blocks coding-blocks deleted a comment May 17, 2018
@coding-blocks coding-blocks deleted a comment May 17, 2018
@codecov
Copy link

codecov bot commented May 17, 2018

Codecov Report

Merging #71 into master will decrease coverage by 0.05%.
The diff coverage is 15%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #71      +/-   ##
============================================
- Coverage     27.39%   27.34%   -0.06%     
  Complexity       33       33              
============================================
  Files            83       83              
  Lines          1865     1854      -11     
  Branches         91       91              
============================================
- Hits            511      507       -4     
+ Misses         1319     1312       -7     
  Partials         35       35
Impacted Files Coverage Δ Complexity Δ
...italoceanapp/activities/DetailDropletActivity.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...osc/digitaloceanapp/activities/SplashActivity.java 20% <100%> (-1.57%) 0 <0> (ø)
...italoceanapp/activities/DropletCreateActivity.java 38.8% <28.57%> (-2.63%) 0 <0> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a793a3...6f710d8. Read the comment docs.

@coding-blocks coding-blocks deleted a comment May 17, 2018
@coding-blocks coding-blocks deleted a comment May 17, 2018
@coding-blocks coding-blocks deleted a comment May 17, 2018
@coding-blocks coding-blocks deleted a comment May 17, 2018
@AkshayCHD
Copy link
Author

@championswimmer the codeclimate test renders ambiguous results, rest all tests have passed, please have a look

@4lch4
Copy link
Contributor

4lch4 commented May 17, 2018

@AkshayCHD could you not move the lines that codeclimate are complaining about to their own method?

It seems to just be complaining that some code is similar (lines 207/235), which could be moved to a single method with parameters and that should fix it.

EDIT: I haven't actually looked at the code in its entirety so I'm not sure how feasible this is, hence my asking. Forgot to mention this part.

@AkshayCHD
Copy link
Author

@alcha actually the problem is that the codes represent two cases of a switch case and although the codes look similar there are alot of case specific variables in each case. So if i create a common function i would have an overhead of checking again and again which case is it, which is not desired in my opinion. I could be wrong about it, I don't know for sure, but thank you for the suggestion.

@4lch4
Copy link
Contributor

4lch4 commented May 17, 2018

Ahhh, that makes sense then. No worries 😊

@coding-blocks coding-blocks deleted a comment May 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add databinding in activities
3 participants