Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ご飯ボタンをおしてから離脱した時、戻ってきたら初期アニメーションから始まるようにする #15

Merged
merged 2 commits into from
Apr 8, 2024

Conversation

k1tikurisu
Copy link
Member

@k1tikurisu k1tikurisu commented Apr 8, 2024

close #13

wait中に離脱した場合、throwしてcatch節に入り残りの処理をスキップするようにした

のちにリファクタリングしたい(関数名含め)

下記のそれぞれが問題ないことを確認(逆にprod環境のは全部変な挙動になることも確認)

  • feedボタンを押してすぐ離脱
  • bend中に離脱
  • eat中に離脱

@k1tikurisu k1tikurisu added the bug Something isn't working label Apr 8, 2024
@k1tikurisu k1tikurisu requested a review from hyphen-o April 8, 2024 03:57
@k1tikurisu k1tikurisu self-assigned this Apr 8, 2024
@k1tikurisu k1tikurisu changed the title wait中に離脱したらrejectするように ご飯ボタンをおしてから離脱した時、戻ってきたら初期アニメーションから始まるようにする Apr 8, 2024
Copy link
Contributor

@hyphen-o hyphen-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

問題なさそう!
ありがとう!

@hyphen-o hyphen-o merged commit 1d8d5a0 into main Apr 8, 2024
1 check passed
@hyphen-o hyphen-o deleted the fix/#13 branch April 8, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feed中に他のデスクトップに移して戻ってくると表示が変になる
2 participants