fix: read default acl from config

coding-socks · Apr 1, 2024 · d332514 · d332514
1 parent 98cb962
commit d332514
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 5 deletions.
diff --git a/config/multipart-of-madness.php b/config/multipart-of-madness.php
@@ -20,6 +20,21 @@
 
  'storage_disk' => env('MULTIPART_OF_MADNESS_DISK', 's3'),
 
+ /*
+ |--------------------------------------------------------------------------
+ | Default ACL
+ |--------------------------------------------------------------------------
+ |
+ | This option controls the default ACL that will be used by the controller
+ | when signed URL needs to be created. You may set this to any of the
+ | canned ACLs available in AWS S3.
+ |
+ | https://docs.aws.amazon.com/AmazonS3/latest/userguide/acl-overview.html#canned-acl
+ |
+ */
+
+ // 'acl' => 'public-read',
+
  /*
  |-------------------------------------
  | Routes configurations

diff --git a/src/Http/Controller/S3MultipartController.php b/src/Http/Controller/S3MultipartController.php
@@ -51,10 +51,8 @@ public function uploadParameters(Request $request)
  'content-type' => $data['type'],
  ];
 
- // TODO: read optional ACL from config
-
- foreach ($data['metadata'] as $key => $value) {
- $params["x-amz-meta-{$key}"] = $value;
+ if ($acl = config('multipart-of-madness.acl')) {
+ $params['ACL'] = $acl;
  }
 
  $key = implode('-', [Str::random(), $data['filename']]);
@@ -99,7 +97,9 @@ public function create(Request $request)
  'Metadata' => $this->encodeMetadata($data['metadata']),
  ];
 
- // TODO: read optional ACL from config
+ if ($acl = config('multipart-of-madness.acl')) {
+ $params['ACL'] = $acl;
+ }
 
  $result = $this->adapter->createMultipartUpload($key, $params);