What is the relevance of this copy?

[1r00t]

django-pictures/pictures/models.py

Line 75 in acb0a0d

image = image.copy()

What is the relevance of this copy?
Maybe the fix for image rotation (#68) would make this line irrelevant?

[codingjoe]

Hi @1r00t,

Excellent question. This is to avoid state leakage. If you iterate over all sizes and don't create a copy before applying any changes to the object, the state will leak to the next iteration of the loop.

I believe this line was part of a bug fix from @vchrisb who discovered this issue.

Cheers,
Joe

[1r00t]

Perfect, so the exif_transpose function could replace this copy because it will itself create a copy. From the ImageOps reference:

If an image has an EXIF Orientation tag, other than 1, return a new image that is transposed accordingly. The new image will have the orientation data removed.

Otherwise, return a copy of the image.

It still needs to be tested