Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude empty objects during picture migration #120

Merged
merged 3 commits into from
Aug 15, 2023

Conversation

amureki
Copy link
Collaborator

@amureki amureki commented Aug 15, 2023

No description provided.

@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (bd8dca6) 100.00% compared to head (ac95fe4) 100.00%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #120   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           13        13           
  Lines          448       449    +1     
=========================================
+ Hits           448       449    +1     
Flag Coverage Δ
celery 85.30% <100.00%> (+0.03%) ⬆️
cleanup 85.96% <100.00%> (+0.03%) ⬆️
dj4.1 85.96% <100.00%> (+0.03%) ⬆️
dj4.2 85.96% <100.00%> (+0.03%) ⬆️
dramatiq 85.30% <100.00%> (+0.03%) ⬆️
drf 93.98% <100.00%> (+0.01%) ⬆️
macos-latest 86.19% <100.00%> (+0.03%) ⬆️
py3.10 85.96% <100.00%> (+0.03%) ⬆️
py3.8 85.96% <100.00%> (+0.03%) ⬆️
py3.9 85.96% <100.00%> (+0.03%) ⬆️
ubuntu-latest 85.96% <100.00%> (+0.03%) ⬆️
windows-latest 78.30% <100.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
pictures/migrations.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@codingjoe codingjoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent catch, thanks @amureki

@codingjoe codingjoe merged commit 85b61d4 into codingjoe:main Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants