Resolve #122 -- Add Django-RQ support for async image processing

[krtko1]

• django-rq: add django-rq support
• django-rq: test django-rq support

[krtko1]

resolves #122

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5aabd50) 100.00% compared to head (c781277) 100.00%.
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff            @@
##              main      #124   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           13        13           
  Lines          449       459   +10     
=========================================
+ Hits           449       459   +10     

Flag	Coverage Δ
celery	84.31% <40.00%> (-0.99%)	⬇️
cleanup	84.96% <40.00%> (-1.01%)	⬇️
dj4.1	84.96% <40.00%> (-1.01%)	⬇️
dj4.2	84.96% <40.00%> (-1.01%)	⬇️
django-rq	84.31% <80.00%> (?)
dramatiq	84.31% <40.00%> (-0.99%)	⬇️
drf	92.81% <40.00%> (-1.18%)	⬇️
macos-latest	85.18% <40.00%> (-1.01%)	⬇️
py3.10	84.96% <40.00%> (-1.01%)	⬇️
py3.12	84.96% <40.00%> (-1.01%)	⬇️
py3.8	84.96% <40.00%> (-1.01%)	⬇️
py3.9	84.96% <40.00%> (-1.01%)	⬇️
ubuntu-latest	84.96% <40.00%> (-1.01%)	⬇️
windows-latest	77.04% <40.00%> (-1.26%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[codingjoe]

Excellent, this looks like a promising start. I approved the CI run for you. Unfortunately, the setup isn't working yet. Redis is currently only installed for dramatiq:

django-pictures/.github/workflows/ci.yml

Lines 140 to 141 in 2ad81c7

	- name: Install redis
	if: matrix.extras == 'dramatiq'

A little … || matrix.extras == 'django-rq' should do the trick.

[krtko1]

@codingjoe Can you look at this?

[krtko1]

ping?

[codingjoe]

Hi, please excuse the delay. I took me a little while to catch up with all my notifications on GitHub.

[codingjoe]

Hi @krtko1 the CI suite still fails. Let me know if you ned any help to fix it. I merged the latest main branch into your feature branch, to enable Python 3.12 tests as well. Cheers! Joe

[codingjoe]

OK, I took the liberty and pushed this over the finish line. Took me a minute, since I have never used Django-RQ. Buuut, I think I managed well. Enjoy!

[krtko1]

Thanks a lot