-
-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #144 -- Improve DRM serialization performance by filtering source and ratio #148
Fix #144 -- Improve DRM serialization performance by filtering source and ratio #148
Conversation
cbe1255
to
2f94b4c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #148 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 13 13
Lines 459 470 +11
=========================================
+ Hits 459 470 +11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent! This looks promising, I left you several fussy comments. But overall, once you add test, for the new kwargs, this is ready to ship.
@codingjoe got me to the question - should we handle cases when user only provides aspect ratio OR image source? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @amureki
This is an early draft of a possible direction.
I did not go all fancy and did not add tests before I validate this with you.
The manual test on 5000 objects showed me this: