Improve migration performance #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
codingjoe
commented
May 5, 2024
codingjoe
commented
- perform delete IO async
- create only newly added sizes
- delete only obsolete file sizes
- create sizes from an in-memory copy of the file
codingjoe
force-pushed
the
async-migrations
branch
3 times, most recently
from
117b591 to
aae65ef
Compare
codingjoe
force-pushed
the
async-migrations
branch
2 times, most recently
from
d5bb268 to
23ace56
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| file_name: str, | ||
| new: list[tuple[str, list, dict]] | None = None, | ||
| old: list[tuple[str, list, dict]] | None = None, | ||
| ) -> None: ... |
Check notice
Code scanning / CodeQL
Statement has no effect Note
codingjoe
force-pushed
the
async-migrations
branch
from
23ace56 to
09db21a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #169 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 13 13
Lines 466 488 +22
=========================================
+ Hits 466 488 +22
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
* perform delete IO async * create only newly added sizes * delete only obsolete file sizes * create sizes from an in-memory copy of the file
codingjoe
force-pushed
the
async-migrations
branch
from
09db21a to
b9b5ce1
Compare
amureki
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.