Skip to content

Update Dockerfile #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 3, 2023
Merged

Update Dockerfile #139

merged 1 commit into from
Dec 3, 2023

Conversation

gu4xin1m
Copy link
Contributor

Fixing the dependency error. Certifi's last python 2.7 release is 2020.04.5, otherwise the docker run command will raise a error.

@gu4xin1m
Update Dockerfile
15aeec1 
Fixing the dependency error. Certifi's last python 2.7 release is 2020.04.5, otherwise the docker run command will raise a error.
@daniel-corcoran
Copy link

I tested this patch and it solved the issue for me... Please accept

daniel-corcoran
daniel-corcoran approved these changes Nov 7, 2023
View reviewed changes
Copy link

@daniel-corcoran daniel-corcoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works!!

@fabiand93
Copy link

Will be testing in a moment

fabiand93
fabiand93 approved these changes Nov 7, 2023
View reviewed changes
Copy link

@fabiand93 fabiand93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works but requirements shouldn't be directly into Dockerfiles but requirements list
By now this leaves the application working vs not executable.

@codingo codingo merged commit efe6f7a into codingo:master Dec 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabiand93 fabiand93 fabiand93 approved these changes

@daniel-corcoran daniel-corcoran daniel-corcoran approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gu4xin1m @daniel-corcoran @fabiand93 @codingo