forked from benlings/scala-guice
-
Notifications
You must be signed in to change notification settings - Fork 44
Support bindInterceptor[T1, T2] #41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
package net.codingwell.scalaguice; | ||
|
||
import java.lang.annotation.ElementType; | ||
import java.lang.annotation.Retention; | ||
import java.lang.annotation.RetentionPolicy; | ||
import java.lang.annotation.Target; | ||
|
||
|
||
/** | ||
* There is no support for runtime annotation in Scala, so far | ||
* Java interfaces need to be used. | ||
*/ | ||
@Retention(RetentionPolicy.RUNTIME) | ||
@Target(ElementType.METHOD) | ||
public @interface AOP { | ||
|
||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -15,9 +15,8 @@ | |
*/ | ||
package net.codingwell.scalaguice | ||
|
||
import org.scalatest.{Matchers, WordSpec} | ||
|
||
import com.google.inject._ | ||
import org.scalatest.{Matchers, WordSpec} | ||
|
||
class ScalaModuleSpec extends WordSpec with Matchers { | ||
|
||
|
@@ -78,7 +77,7 @@ class ScalaModuleSpec extends WordSpec with Matchers { | |
} | ||
|
||
"allow binding with annotation using a type parameter" in { | ||
import name.Named | ||
import com.google.inject.name.Named | ||
val module = new AbstractModule with ScalaModule { | ||
def configure() = { | ||
bind[A].annotatedWith[Named].to[B] | ||
|
@@ -123,6 +122,17 @@ class ScalaModuleSpec extends WordSpec with Matchers { | |
twoStrings.first should be ("first") | ||
twoStrings.second should be ("second") | ||
} | ||
|
||
"allow binding annotation interceptor" in { | ||
val module = new AbstractModule with ScalaModule { | ||
def configure() = { | ||
bind[Say].to[SayHi] | ||
bindInterceptor[AOPI](methodMatcher = annotatedWith[AOP]) | ||
} | ||
} | ||
val say = Guice.createInjector(module).getInstance(classOf[Say]) | ||
say.hi("Bob") should be ("Hi Bob") | ||
} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. For bonus points, you're welcome to add a test with a class annotated with AOP. But by no means is that a requirement to merge this! |
||
} | ||
|
||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer to see a test that checks that the interceptor intercepts an annotated method.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok